Adding the option to set default vlan

[AlonaKaplan]

Adding the option to set default vlan

This change is needed by ManageIQ/manageiq-providers-ovirt#150.
PR ManageIQ/manageiq-providers-ovirt#150 is automatically setting a default 'vlan' on a vm provision. It is done by overriding 'miq_provison_workflow.set_default_vlan' method, introduced in this PR.
Since a default vlan is set, there is no need for the 'vlan' field to be required.

Fixes https://bugzilla.redhat.com/1449157

[gmcculloug]

@AlonaKaplan I assume you are doing this to override in a provider. Is there a PR in a separate repo that relies on this change that can be linked here.

[AlonaKaplan]

needed by ManageIQ/manageiq-providers-ovirt#150

[agrare]

@AlonaKaplan can you add a description of what this change is going to do? Are you trying to add a <Template> network option if nothing else is specified?

[AlonaKaplan]

@agrare Exactly. If nothing else is specified, which means, keep the template vnics, we be chosen.

[AlonaKaplan]

@agrare can this PR be approved/merged?

[agrare]

@AlonaKaplan can you add a description of what you're trying to do and some background in the PR description instead of a comment?

[AlonaKaplan]

@agrare updated the PR description.

[agrare]

@gmcculloug could we just make the redhat provision dialog default to <Template> instead of having to add this?

[AlonaKaplan]

@agrare what is blocking this PR from being merged? @gmcculloug do you have an answer to Adam's questions?

[agrare]

what is blocking this PR from being merged?

Just that this seems like a weird way to set a default value in a provision dialog. If there isn't a better way to do this then maybe vlan ||= default_vlan where you can set def default_vlan; "<Template>"; end in the provider repo

[gmcculloug]

@agrare I would hope that setting a default value on the field in the dialog yaml file would work, but would need to be tested since the logic here is trying to set the default based on the source VM might be messing with the normal default logic.

If that does not work I do like the idea of using vlan ||= default_vlan, but to take it one step further the default_vlan method could load the field and and pull the value from there. A little round-about but it would still allow the user to modify the default from the dialog as they would expect.

[miq-bot]

Checked commit AlonaKaplan@f997fd5 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[AlonaKaplan]

@agrare @gmcculloug the code was updated per your request.

[agrare]

Looks much better! I'll leave this up to @gmcculloug though as I'm not as familiar with the miq_request_workflow

[AlonaKaplan]

@gmcculloug can you please review?

[gmcculloug]

@AlonaKaplan Agreed that this is a much nicer solution. I think you also want to apply the changes to the miq_provision_redhat_dialogs_clone_to_vm.yaml file.

[AlonaKaplan]

@miq-bot add_label gaprindashvili/yes

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit af1170b93c9e174def52c8c9fb7b8f39b2a1a890
Author: Greg McCullough <[email protected]>
Date:   Wed Jan 10 13:32:52 2018 -0500

    Merge pull request #16504 from AlonaKaplan/master
    
    Adding the option to set default vlan
    (cherry picked from commit 30631c2f1a8d9bcd964b8fa85a1870f8fa07993e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1533499