Fix save_tags_inventory spec: assign the tag, not the catogory #16499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ManageIQ#16453, I changed this spec to "realistically" create a tag mapping + category + tag. But I made a typo/thinko, taking the parent (category) tag to be assigned to the vm. This caused false failure for ManageIQ#16449 and days of lost work debugging/rewriting it, eventually caused similar failure in the rewrite too :-( https://bugzilla.redhat.com/show_bug.cgi?id=1508437
|
Checked commit cben@1509ecb with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Nov 20, 2017
agrare
approved these changes
Nov 20, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 21, 2017
Fix save_tags_inventory spec: assign the tag, not the catogory (cherry picked from commit 54c7caf)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16453, I changed this spec to "realistically" create a tag mapping + category + tag.
But I made a typo/thinko, taking the parent (category) tag to be assigned to the vm.
This caused false failure for #16449 and days of lost work debugging/rewriting it, eventually caused similar failure in the rewrite too :-(
Well, at least now I'll have 2 approaches to choose from :-)
@miq-bot add-label test, bug, gaprindashvili/yes
@agrare Please review