Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed MiqAlerts used for Prometheus Alerts #16479

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Seed MiqAlerts used for Prometheus Alerts #16479

merged 1 commit into from
Nov 16, 2017

Conversation

moolitayer
Copy link

@moolitayer moolitayer commented Nov 15, 2017 •
edited
Loading

These two alerts profiles are used for the Prometheus Alerts Integration Seeding them would make setup a little easier.

alert_profiles_seed

@moolitayer
Copy link
Author

@miq-bot assign @gmcculloug
@miq-bot add_label gaprindashvili/yes, enhancement, alerts

@moolitayer
Copy link
Author

cc @ilackarms @joelddiaz

@moolitayer moolitayer changed the title Seed MiqAlerts used for Prometheus Alerts [WIP] Seed MiqAlerts used for Prometheus Alerts Nov 15, 2017
@moolitayer
Copy link
Author

@miq-bot add_label wip
Exploring an option to seed miq alert sets

@miq-bot miq-bot added the wip label Nov 15, 2017
@moolitayer moolitayer changed the title [WIP] Seed MiqAlerts used for Prometheus Alerts Seed MiqAlerts used for Prometheus Alerts Nov 15, 2017
@moolitayer
Copy link
Author

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Nov 15, 2017
@gmcculloug gmcculloug requested a review from gtanzillo November 15, 2017 20:14
@gmcculloug
Copy link
Member

@gtanzillo Hoping you can help look over this PR or add someone from your team.

gtanzillo
gtanzillo reviewed Nov 15, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you add a test for it?

@moolitayer moolitayer force-pushed the prometheus_seed branch 3 times, most recently from aff6687 to 0139be8 Compare November 16, 2017 08:37
@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2017

Checked commit moolitayer@57e875c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@moolitayer
Copy link
Author

@gtanzillo added a couple of tests, please take a look

gtanzillo
gtanzillo approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the tests 👍

@gmcculloug gmcculloug merged commit 6bdb97e into ManageIQ:master Nov 16, 2017
@gmcculloug gmcculloug added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 16, 2017
simaishi pushed a commit that referenced this pull request Nov 17, 2017
@gmcculloug @simaishi
Merge pull request #16479 from moolitayer/prometheus_seed
df82c40 
Seed MiqAlerts used for Prometheus Alerts
(cherry picked from commit 6bdb97e)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit df82c40de0e11187f59da1420b8cac8879759c85
Author: Greg McCullough <[email protected]>
Date:   Thu Nov 16 09:08:42 2017 -0500

    Merge pull request #16479 from moolitayer/prometheus_seed
    
    Seed MiqAlerts used for Prometheus Alerts
    (cherry picked from commit 6bdb97e3563758159e5fdc8c562990a74ade41ab)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gmcculloug gmcculloug

Labels
core/alerts enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moolitayer @gmcculloug @miq-bot @simaishi @gtanzillo