Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] Remove models that do not have API/UI support for custom actions #16467

Merged

Conversation

gmcculloug
Copy link
Member

For the initial Gaprindashvili release we agreed to limit the models that are exposed as custom buttons while work continues to expose the required models and actions through the API and enable the ui-components dialog runner for each object.

cc @eclarizio @d-m-u @jntullo

@gmcculloug gmcculloug requested a review from abellotti November 14, 2017 02:14
@miq-bot miq-bot changed the title Remove models that do not have API/UI support for custom actions [GAPRINDASHVILI] Remove models that do not have API/UI support for custom actions Nov 14, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2017

Checked commit gmcculloug@68a2894 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gmcculloug
Copy link
Member Author

@Fryguy Please review

Copy link
Member

@abellotti abellotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Also, updated the related manageiq-api PR with g/yes and g/no.

@Fryguy Fryguy merged commit adaf849 into ManageIQ:gaprindashvili Nov 15, 2017
@Fryguy
Copy link
Member

Fryguy commented Nov 15, 2017

Gahhhhh... @simaishi I accidentally merged to gaprindashvili.

@Fryguy Fryguy added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 15, 2017
@Fryguy Fryguy added the cleanup label Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants