Added a Maintenance key to the hash struct #16464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement, bug, providers @miq-bot assign @gmcculloug cc - @h-kataria |
|
Checked commit syncrou@a1893e9 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@syncrou we usually stay away from database defaults but you're right the ovirt parser should be setting the maintenance flag. It looks like maintenance is in the power state so it should be a simple change |
|
@syncrou I suggest we move forward with this change and open an issue in the manageiq-providers-ovirt repo to set the host maintenance data. |
|
@masayag can you create a bug on the maintenance issue reported here? |
masayag
added a commit
to masayag/manageiq-providers-ovirt
that referenced
this pull request
Nov 15, 2017
The host 'maintenance' attribute was added to provision vm dialog by ManageIQ/manageiq#16464 RHV should store this information which is already available during host refresh. https://bugzilla.redhat.com/show_bug.cgi?id=1513413
masayag
added a commit
to masayag/manageiq-providers-ovirt
that referenced
this pull request
Nov 16, 2017
The host 'maintenance' attribute was added to provision vm dialog by ManageIQ/manageiq#16464 RHV should store this information which is already available during host refresh. https://bugzilla.redhat.com/show_bug.cgi?id=1513413
masayag
added a commit
to masayag/manageiq-providers-ovirt
that referenced
this pull request
Nov 16, 2017
The host 'maintenance' attribute was added to provision vm dialog by ManageIQ/manageiq#16464 RHV should store this information which is already available during host refresh. https://bugzilla.redhat.com/show_bug.cgi?id=1513413
simaishi
pushed a commit
that referenced
this pull request
Nov 17, 2017
Added a Maintenance key to the hash struct (cherry picked from commit 8ba842c) https://bugzilla.redhat.com/show_bug.cgi?id=1514116
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
maintenancekey our hash_struct for use in the UIAllows us to view if a
hostis in Maintenance mode.https://bugzilla.redhat.com/show_bug.cgi?id=1506268