Revert "Replace ContainerLabelTagMapping.controls_tag? with Tag.controlled_by_mapping scope" #16462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olled_by_mapping scope"
|
@cben I'm just going to do a full revert so we don't have any strange errors with graph refresh and tagging, given that graph refresh is now the default. It is easier to understand it 100% not working :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative option to #16461 — fully reverts #16449
It broke save_tags_inventory_spec https://travis-ci.org/ManageIQ/manageiq/jobs/301542779#L1054
It seems
Tag.controlled_by_mappingworks right butentity.tags.controlled_by_mappingdoesn't (?)Will debug more tomorrow.
cc @agrare My laptop battery is running out, so leaving choice to you :)