Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scope :without_configuration_profile_id needed by Foreman explorer UI #16439

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Add scope :without_configuration_profile_id needed by Foreman explorer UI #16439

merged 1 commit into from
Nov 10, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Nov 10, 2017 •
edited
Loading

@martinpovolny martinpovolny mentioned this pull request Nov 10, 2017
Closed
@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2017

Checked commit martinpovolny@9085771 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/models/configured_system.rb

@martinpovolny martinpovolny mentioned this pull request Nov 10, 2017
Merged
Ladas
Ladas approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@martinpovolny martinpovolny changed the title [WIP] Add scope :without_configuration_profile_id needed by Foreman explorer UI Add scope :without_configuration_profile_id needed by Foreman explorer UI Nov 10, 2017
@martinpovolny martinpovolny removed the wip label Nov 10, 2017
@agrare agrare merged commit e5b50ff into ManageIQ:master Nov 10, 2017
@agrare agrare added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 10, 2017
@agrare agrare self-assigned this Nov 10, 2017
simaishi pushed a commit that referenced this pull request Nov 14, 2017
@agrare @simaishi
Merge pull request #16439 from martinpovolny/foreman_scope
bf88ee6 
Add scope :without_configuration_profile_id needed by Foreman explorer UI
(cherry picked from commit e5b50ff)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit bf88ee6491dd18fe0e3a990aa46792d7afe6feba
Author: Adam Grare <[email protected]>
Date:   Fri Nov 10 09:17:31 2017 -0500

    Merge pull request #16439 from martinpovolny/foreman_scope
    
    Add scope :without_configuration_profile_id needed by Foreman explorer UI
    (cherry picked from commit e5b50ff099ecc800e6443325bbb792b387ec7926)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@Ladas Ladas Ladas approved these changes

@lpichler lpichler Awaiting requested review from lpichler

@tumido tumido Awaiting requested review from tumido

Assignees

@agrare agrare

Labels
core/reporting gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @simaishi @Ladas @agrare