Refresh new target do not run post_refresh

[pkliczewski]

In case when we run refresh_new_target a vm is created before the
refresh was run so we need to make sure it is picked up by post_refresh.

Bug-Url:
https://bugzilla.redhat.com/1510459

[pkliczewski]

Bug 1510459 - cfme ignores create vm events from rvh41 provider

[pkliczewski]

@miq-bot add_label gaprindashvili/yes

[pkliczewski]

@miq-bot assign @agrare

[agrare]

This seems really hacky, lets see if there's a better way to do this.

[pkliczewski]

I am open for suggestions. We use time to determine which the vm was created so I wonder what we can do here.

[agrare]

Yeah I'm thinking if we could try to get update_start_time from when refresh_new_target started, haven't checked if that is feasible yet

[oourfali]

@agrare @pkliczewski any updates on your side?

[agrare]

@pkliczewski could you just call #post_create_actions_queue from refresh_new_target if the vm was created instead of messing with the ems_refresh_start_time?

[pkliczewski]

@agrare will try

[agrare]

@pkliczewski this looks much cleaner, did you confirm it works?

If you make these changes the specs are passing locally for me:

   context '.refresh_new_target' do
-    let(:ems) { FactoryGirl.create(:ems_vmware) }
+    let(:ems) do
+      _, _, zone = EvmSpecHelper.create_guid_miq_server_zone
+      FactoryGirl.create(:ems_vmware, :zone => zone)
+    end

[pkliczewski]

@agrare I checked that there are no failures. Will update the spec.

[miq-bot]

Checked commit pkliczewski@4284854 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 0c6620d30ba31b36f92147bd1ae17da2c2349595
Author: Adam Grare <[email protected]>
Date:   Fri Nov 17 09:26:03 2017 -0500

    Merge pull request #16436 from pkliczewski/master
    
    Refresh new target do not run post_refresh
    (cherry picked from commit 013c7b4cd84c54a0d8e771da5b77fcdc09b195a4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1514509