Fix nil cases of allocated disk types in chargeback reporting #16434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized: gapridashvili/yes |
|
@miq-bot add_label gaprindashvili/yes |
lpichler
force-pushed
the
fix_nil_cases_of_allocated_disk_types
branch
from
f095fa6 to
631ee29
Compare
lpichler
force-pushed
the
fix_nil_cases_of_allocated_disk_types
branch
from
631ee29 to
c18d0c0
Compare
gtanzillo
suggested changes
Nov 14, 2017
| expect(consumption.send(:values, 'derived_vm_allocated_disk_storage', sub_metric)).to match_array([0]) | ||
| end | ||
|
|
||
| context 'vim performance state contains any state date for storage' do |
There was a problem hiding this comment.
Minor typo - date should be data
VimPerformanceState#allocated_disk_types is dynamic method, which is only accessing VimPerformanceState#state_data[:allocated_disk_types] this fix is handling situation when VimPerformanceState#state_data is nil VimPerformanceState#state_data[:allocated_disk_types] is nil VimPerformanceState#state_data[:allocated_disk_types][sub_metric] is nil and replacing it by 0
lpichler
force-pushed
the
fix_nil_cases_of_allocated_disk_types
branch
from
c18d0c0 to
a1579ec
Compare
|
@gtanzillo thanks , fixed 👍 |
|
Checked commits lpichler/manageiq@71e249b~...a1579ec with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
lpichler
changed the title
lpichler
changed the title
|
@miq-bot remove_label wip |
gtanzillo
approved these changes
Nov 27, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
…sk_types Fix nil cases of allocated disk types in chargeback reporting (cherry picked from commit a807056) https://bugzilla.redhat.com/show_bug.cgi?id=1517956
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nil cases and use 0
VimPerformanceState#allocated_disk_types
is dynamic method, which is only accessing
VimPerformanceState#state_data[:allocated_disk_types]
this fix is handling situation when
VimPerformanceState#state_data is nil
VimPerformanceState#state_data[:allocated_disk_types] is nil
VimPerformanceState#state_data[:allocated_disk_types][sub_metric] is nil
and replacing it by 0
@miq-bot assign @gtanzillo
@miq-bot add_label gapridashvili/yes, bug, chargeback