Fix has_required_role? for InventoryCollectorWorker #16415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was skipping the base MiqWorker.has_required_role? code checking for active roles and instead just looking for the disabled setting.
|
Checked commit agrare@1874de3 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@agrare needed for Gaprindashvili? |
agrare
added a commit
to agrare/manageiq-providers-kubernetes
that referenced
this pull request
Nov 8, 2017
The has_required_role? method wasn't calling the base MiqWorker#has_required_role? leading to all workers in the zone running the inventory collector. Depends: ManageIQ/manageiq#16415
agrare
added a commit
to agrare/manageiq-providers-openshift
that referenced
this pull request
Nov 8, 2017
The has_required_role? method wasn't calling the base MiqWorker#has_required_role? leading to all workers in the zone running the inventory collector. Depends: ManageIQ/manageiq#16415
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
…has_required_roles Fix has_required_role? for InventoryCollectorWorker (cherry picked from commit af45409)
|
Gaprindashvili backport details: |
yaacov
pushed a commit
to yaacov/manageiq-providers-kubernetes
that referenced
this pull request
Dec 10, 2017
The has_required_role? method wasn't calling the base MiqWorker#has_required_role? leading to all workers in the zone running the inventory collector. Depends: ManageIQ/manageiq#16415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was skipping the base MiqWorker.has_required_role? code checking
for active roles and instead just looking for the disabled setting.