Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print name instead of manager ref #16411

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Print name instead of manager ref #16411

merged 2 commits into from
Nov 7, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Nov 7, 2017 •
edited
Loading

Print name instead of manager_ref and test we support all types of targets.

Ladas added 2 commits November 7, 2017 18:28
@Ladas
Print name instead of manager_ref
35855d3 
Print name instead of manager_ref, since manager_ref is not
supported by other targets like Vm.
@Ladas
Test that we support all possible targets
802a935 
Test that we support all possible targets
@Ladas Ladas changed the title Log name instead of manager ref Print name instead of manager ref Nov 7, 2017
@Ladas
Copy link
Contributor Author

Ladas commented Nov 7, 2017

@miq-bot assign @agrare

@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2017

Checked commits Ladas/manageiq@35855d3~...802a935 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member

agrare commented Nov 7, 2017

@pkliczewski @jhernand can you test to confirm it fixes your test failures?

@jhernand
Copy link
Contributor

jhernand commented Nov 7, 2017

I can confirm that this solves the test failures. Thanks @Ladas and @agrare!

@agrare agrare merged commit 543bf24 into ManageIQ:master Nov 7, 2017
@agrare
Copy link
Member

agrare commented Nov 7, 2017

Introduced by #16405

@agrare agrare added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 7, 2017
@jhernand jhernand mentioned this pull request Nov 7, 2017
Merged
simaishi pushed a commit that referenced this pull request Nov 7, 2017
@agrare @simaishi
Merge pull request #16411 from Ladas/log_name_instead_of_manager_ref
ed87902 
Print name instead of manager ref
(cherry picked from commit 543bf24)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit ed87902fbea170445b55c9b8da6718a778119ab9
Author: Adam Grare <[email protected]>
Date:   Tue Nov 7 13:23:30 2017 -0500

    Merge pull request #16411 from Ladas/log_name_instead_of_manager_ref
    
    Print name instead of manager ref
    (cherry picked from commit 543bf24e18eaf01f3ed56b02fd14f590423c4620)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agrare agrare

Labels
bug gaprindashvili/backported providers/inventory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ladas @miq-bot @agrare @jhernand @simaishi