Added User Agent to VMDB::Appliance #16410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Nov 7, 2017
lib/vmdb/appliance.rb
Outdated
| end | ||
|
|
||
| def self.USER_AGENT | ||
| "#{self.PRODUCT_NAME}/#{self.VERSION}".freeze |
There was a problem hiding this comment.
Cool...you don't need the self. bits.
There was a problem hiding this comment.
I can never remember if an when you need self
juliancheal
force-pushed
the
add_user_agent
branch
from
6cf1c34 to
63ace8d
Compare
This was referenced Nov 7, 2017
juliancheal
force-pushed
the
add_user_agent
branch
from
63ace8d to
698f0bb
Compare
|
This pull request is not mergeable. Please rebase and repush. |
juliancheal
force-pushed
the
add_user_agent
branch
from
698f0bb to
9c21789
Compare
|
@Fryguy hadn't noticed this was marked as unmergable. Rebased and all good now. |
|
Checked commit juliancheal@9c21789 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/vmdb/appliance.rb
|
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Added User Agent to VMDB::Appliance (cherry picked from commit e3b166f)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on PR from #16409 adding a user agent string.