-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ems_infra_admin_ui feature #16403
Conversation
0b47f54
to
281c143
Compare
@@ -86,6 +86,7 @@ module SupportsFeatureMixin | |||
:discovery => 'Discovery of Managers for a Provider', | |||
:evacuate => 'Evacuation', | |||
:launch_cockpit => 'Launch Cockpit UI', | |||
:admin_ui => 'Open Admin UI for a Provider', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to add oVirt somewhere in the description, and maybe also in the name of the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw in other pull request that you are adding a supports
mechanism to the provider. If that is going to be generic then you can disregard this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've consulted this with @himdel and decided to make this feature generic - each Infra Provider would have the option to support the admin_ui
product feature.
db/fixtures/miq_product_features.yml
Outdated
@@ -6526,7 +6530,7 @@ | |||
- :name: Switch Language | |||
:description: Display Language options | |||
:feature_type: view | |||
:identifier: sui_language | |||
:identifier: sui_language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better if you don't do unrelated fixes in this pull request. If you think these should be fixed, do it in a separate pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. My IDE automatically strips trailing whitespace. I'll revert those changes.
Signed-off-by: Vojtech Szocs <[email protected]>
281c143
to
9c34aed
Compare
Checked commit vojtechszocs@9c34aed with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/models/mixins/supports_feature_mixin.rb
|
@simaishi we would like to backport this to 5.9 but I can't find a way how to add the |
@miq-bot add_label gaprindashvili/yes |
Add ems_infra_admin_ui feature (cherry picked from commit 141cdac)
Gaprindashvili backport details:
|
This PR is part of the following series:
The
ems_infra_admin_ui
product feature represents Infrastructure Provider's capability to link to its own (provider-specific) administration UI.This feature is currently associated with
EvmRole-operator
(just likeems_infra_refresh
).Inspired by @jhernand (see original PR here).