Sort array of queue names #16400
Merged
Sort array of queue names #16400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/yes |
|
So I think |
Queue names can get out of numerical order, this can make it tough to compare two arrays of queues as sometimes we need to turn those arrays into Ruby Strings. For example a queue of `["ems_1", "ems_3", "ems_2"]` from the database would not equal `["ems_1", "ems_2", "ems_3"]` if both were strings.
juliancheal
force-pushed
the
order_array_queues
branch
from
3fe13ef to
db6a096
Compare
|
Checked commit juliancheal@db6a096 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Fryguy
reviewed
Nov 6, 2017
| @@ -336,7 +336,7 @@ def self.close_pg_sockets_inherited_from_parent | |||
| # This converts it back to a Ruby Array safely. | |||
| def queue_name | |||
| begin | |||
| JSON.parse(self[:queue_name]) | |||
| JSON.parse(self[:queue_name]).sort | |||
There was a problem hiding this comment.
Will this handle a single queue_name that's not an array?
There was a problem hiding this comment.
@Fryguy that happens here https://github.com/juliancheal/manageiq/blob/db6a096ebd97d09ab0a58d41c5518e3f69a46d58/app/models/miq_worker.rb#L340-L342 If JSON tries to parse a string.
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
Sort array of queue names (cherry picked from commit 619b5b8)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue names can get out of numerical order, this can make it tough
to compare two arrays of queues as sometimes we need to turn those
arrays into Ruby Strings.
For example a queue of
["ems_1", "ems_3", "ems_2"]from the databasewould not equal
["ems_1", "ems_2", "ems_3"]if both were strings.