Add miq_expression setter to MiqAlert #16397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit zakiva@ee1d420 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label enhancement, alerts |
|
@simon3z @moolitayer @imtayadeway Please review |
|
cc @elad661 |
iiuc: This will allow us to create alerts via the API by passing a hash for miq_expression |
Correct. I meant it is part of adding the hash expression option to the API, I will rewrite that :) |
gtanzillo
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type coercion for
miq_expressioncolumn.This will allow us to create alerts via API with miq_expression by passing a hash instead of creating the miq expression object on the API side.
This is part of adding hash_hexpression to the alert definitions API in ManageIQ/manageiq-api#76.