External auth lookup_by_identity should handle missing request parameter #16386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label authentication, bug |
|
@abellotti and or @gtanzillo Please review |
|
Checked commits jvlcek/manageiq@20dd38d~...33ddcc8 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good @jvlcek, I'll do a quick test in a Pod with ext-auth. |
|
just tested fine with an AD enabled Pod. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
External auth lookup_by_identity should handle missing request parameter (cherry picked from commit a03cda1) https://bugzilla.redhat.com/show_bug.cgi?id=1509416
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1505922
Method Httpd#lookup_by_identity has been updated to take an optional parameter but
was not properly handling if the parameter was not provided.
This PR ensures Httpd#lookup_by_identity does the correct thing when the optional request parameter is and is not provided.
Steps for Testing/QA [Optional]
Setup MiQ for External Auth
Log into classic UI, with valid user.
Ensure the error pop-up: "400 /auth/api error message" (see screenshot in BZ) does not appear
and there are not tracebacks in the api.log