update_spid! on timeout, not on each message #16384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1508989 We were issuing many redundant queries per minute per queue worker process because the spid will not change that often. It was originally added a long time ago in: commit fbf3233daefe45c97f18bb486bfdade55ab371f3 Date: Fri May 11 23:49:33 2012 +0000 BugzID:14803 We can eliminate these queries and only do it when we actually reconnect! following a timeout.
|
Checked commit jrafanie@e383939 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
…ing_message update_spid! on timeout, not on each message (cherry picked from commit 9c53f30) https://bugzilla.redhat.com/show_bug.cgi?id=1509420
|
Euwe backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
…ing_message update_spid! on timeout, not on each message (cherry picked from commit 9c53f30) https://bugzilla.redhat.com/show_bug.cgi?id=1509418
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
…ing_message update_spid! on timeout, not on each message (cherry picked from commit 9c53f30) https://bugzilla.redhat.com/show_bug.cgi?id=1509419
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…hen_getting_message update_spid! on timeout, not on each message (cherry picked from commit 9c53f30) https://bugzilla.redhat.com/show_bug.cgi?id=1509419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1508989
We were issuing many redundant queries per minute per queue worker
process because the spid will not change that often.
It was originally added a long time ago in:
commit fbf3233daefe45c97f18bb486bfdade55ab371f3
Date: Fri May 11 23:49:33 2012 +0000
BugzID:14803
We can eliminate these queries and only do it when we actually
reconnect! following a timeout.