Add status and state scopes, fix time for MiqTask list #16365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
commented
Oct 31, 2017
app/models/miq_task.rb
Outdated
| scope :completed_warn, -> { finished.where(:status => 'Warn') } | ||
| scope :completed_error, -> { finished.where(:status => 'Error') } | ||
| scope :no_status_selected, -> { running.where.not(:status => %(Ok Error Warn)) } | ||
| scope :with_status_in, ->(scopes) { scopes[1..-1].reduce(MiqTask.send(scopes.first)) { |chain, s| chain.or(MiqTask.send(s)) } } |
There was a problem hiding this comment.
This is not the most handsome scope out there, I have to admit that. It allows us to chain scopes to get a query like:
scope1 AND scope2 AND (scope3 OR scope4 OR scope5)
using scopes (matching to example above)
:named_scopes => [:scope1, :scope2, [:with_status_in, [:scope3, :scope4, :scope5]]]
There was a problem hiding this comment.
This is an alternative to what previously was an SQL fragment passed around. So while this is not perfect, it's a significant improvement on the current situation.
There was a problem hiding this comment.
The later patch uses splat instead of slices, which is a bit better code...
tumido
force-pushed
the
miq_task_status_as_scope
branch
from
ffec1ca to
f8f555e
Compare
|
Checked commit tumido@f8f555e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM 👍 |
simaishi
pushed a commit
that referenced
this pull request
Nov 3, 2017
Add status and state scopes, fix time for MiqTask list (cherry picked from commit d24d6d7) https://bugzilla.redhat.com/show_bug.cgi?id=1509429
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression brought by: ManageIQ/manageiq-ui-classic#2521
Related: ManageIQ/manageiq-ui-classic#2585
Adding
:stateand:statusbased filtering for tasks view and fix the:updated_onscope, since after a switch to reportdata it stopped working properly (Ruby date range can't be passed as string).