Find_by_queue_name expects a string as queue_name.

[juliancheal]

Multi EMS Workers' queue_names are arrays.

to_s converts the array to a string.

[juliancheal]

@miq-bot add_label bug

[juliancheal]

@miq-bot add_label core/workers

[juliancheal]

@miq-bot assign @Fryguy

[juliancheal]

@Fryguy I can't believe, I went on a wild goose chase to solve this. First "fixing" it in the Amazon Provider, then trying a few other things in the PerEMSMixin to eventually solve it, but adding in a to_s. So annoyed 😡

[juliancheal]

Adding a provider and seeing the workers spawn up

• kill -9 on one of workers and seeing it come back - works
• kill -9 on all of workers and seeing them come back - works
• delete the provider and seeing the workers shut down - works

[juliancheal]

@miq-bot add_label gaprindashvili/yes

[miq-bot]

Checked commit juliancheal@32d8b5e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/models/mixins/per_ems_worker_mixin.rb

• ❗ - Line 73, Col 7 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_queue_name.

[juliancheal]

❗️ - Line 73, Col 7 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_queue_name.

Don't blame me miq-bot legacy!

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 0f663a0b68fb1d5c443731ee7a8ad22914dcd4c5
Author: Jason Frey <[email protected]>
Date:   Tue Oct 31 13:00:10 2017 -0400

    Merge pull request #16359 from juliancheal/fix_stopping_multi_ems_workers
    
    Find_by_queue_name expects a string as queue_name.
    (cherry picked from commit 4fd6cfba969df4f9ad670b6bf69b2c3e74d836d4)