Add back listing of custom attributes in chargeback #16350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
changed the title
lpichler
force-pushed
the
add_custom_attributes_back_to_chargeback
branch
from
3af16bf to
b2a6a30
Compare
lpichler
changed the title
|
@gtanzillo yes, I wanted to add specs 👍 |
|
@miq-bot add_label grapridashvili/yes |
|
@lpichler Cannot apply the following label because they are not recognized: grapridashvili/yes |
lpichler
force-pushed
the
add_custom_attributes_back_to_chargeback
branch
from
b2a6a30 to
c6a6d7e
Compare
lpichler
force-pushed
the
add_custom_attributes_back_to_chargeback
branch
from
c6a6d7e to
86f1048
Compare
|
Checked commits lpichler/manageiq@a66c25a~...86f1048 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
…_chargeback Add back listing of custom attributes in chargeback (cherry picked from commit 6f1588d)
|
Gaprindashvili backport details: |
|
@lpichler Cannot apply the following label because they are not recognized: grapridashvili/yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accidently caused by:
9314672#diff-e5855dfa8cc9aeeeb9d13acd1525499eR929
method
_custom_details_for(cb_model, {})is not related to tags as it could looks on first look.@miq-bot add_label bug, chargeback
@miq-bot assign @gtanzillo
thanks @zeari