Add Custom Buttons and Group features #16332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, can be merged when it turns green |
|
@AparnaKarve looks like you need to update associated spec |
AparnaKarve
force-pushed
the
add_custom_button_feature_refs
branch
from
d288f21 to
b4670da
Compare
|
Checked commit AparnaKarve@b4670da with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@h-kataria @chessbyte Looks like the Feature IDs need to be unique for each new entry added, and I can't reuse the existing IDs. I made the necessary change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Custom Buttons and Group features