Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMS infra: adds Openstack undercloud discovery #16318

Merged
merged 2 commits into from
Feb 23, 2018
Merged

EMS infra: adds Openstack undercloud discovery #16318

merged 2 commits into from
Feb 23, 2018

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Oct 27, 2017 •
edited
Loading

@miq-bot miq-bot added the wip label Oct 27, 2017
@gildub gildub mentioned this pull request Oct 27, 2017
Merged
@agrare
Copy link
Member

agrare commented Jan 18, 2018

@gildub is this still WIP? Looks fine to me

@gildub
Copy link
Contributor Author

gildub commented Jan 22, 2018 •
edited
Loading

@agrare, yes still WIP because the logic behind needs to work to be able to offer the feature and I'm just getting back to it. Thanks!

@gildub gildub changed the title [WIP] EMS infra: Openstack undercloud discovery EMS infra: Openstack undercloud discovery Feb 2, 2018
@miq-bot miq-bot removed the wip label Feb 2, 2018
@gildub gildub mentioned this pull request Feb 14, 2018
Merged
@gildub gildub changed the title EMS infra: Openstack undercloud discovery EMS infra: adds Openstack undercloud discovery Feb 14, 2018
@miq-bot
Copy link
Member

miq-bot commented Feb 21, 2018

Checked commits https://github.com/gildub/manageiq/compare/71e0030adf73aadffb6e70d751f7809c2ebf2f9c~...5d26d4562158052bae776413772451db8e6d4d1c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@gildub
Copy link
Contributor Author

gildub commented Feb 22, 2018

@agrare, now that the network discovery relocation has settled down, re-based and re-tested, it's ready. Thanks

@gildub
Copy link
Contributor Author

gildub commented Feb 22, 2018

@aufi,

As you know it's targeted for coming sub release.
Anyway, there are no impact on existing discovery, this is an add-on.

@aufi
Copy link
Member

aufi commented Feb 23, 2018

Looks good to me 👍

@agrare agrare merged commit dd1fd99 into ManageIQ:master Feb 23, 2018
@agrare agrare added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 23, 2018
@gildub gildub deleted the discovery-openstack-infra branch February 25, 2018 11:40
@gildub
Copy link
Contributor Author

gildub commented Mar 6, 2018

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Mar 8, 2018
@agrare @simaishi
Merge pull request #16318 from gildub/discovery-openstack-infra
7a04dda 
EMS infra: adds Openstack undercloud discovery
(cherry picked from commit dd1fd99)

https://bugzilla.redhat.com/show_bug.cgi?id=1552665
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 7a04ddaa649d815b074f8ee9eb129043799d0b3c
Author: Adam Grare <[email protected]>
Date:   Fri Feb 23 09:42:33 2018 -0500

    Merge pull request #16318 from gildub/discovery-openstack-infra
    
    EMS infra: adds Openstack undercloud discovery
    (cherry picked from commit dd1fd99acbf9e2d480083618f5389d74fa5ecdde)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
enhancement gaprindashvili/backported providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gildub @agrare @miq-bot @aufi @simaishi