use commit time of latest commit for BUILD date

[durandom]

in case a BUILD file is missing we used the current time for
the build time - which can be really confusing

Not using Time.zone on purpose - because we want UTC

This did cost us quite some time in debugging https://bugzilla.redhat.com/show_bug.cgi?id=1491768

The posted build date master.20170914082537_bf64a63 suggested that #15590 which would fix the issue is not on the appliance - but the sha bf64a63 appended to the build version was commited on 2017-08-29 09:54:25

@miq-bot assign @Fryguy

[durandom]

@simaishi can you say when a BUILD file would be missing? I used a .box (vagrant) upstream build and it wasnt there....

[simaishi]

Upstream doesn't have BUILD file, that's downstream only. (I'm not sure why... and I'm thinking we should probably have it upstream too)

[Fryguy]

I don't agree with the date of the last commit. The reason is, you can bundle update on the same commit, get different gems, and the build is still different. Also, the build includes manageiq-aplliance, which is a totally different repo that also has its own commit. IMO, as @simaishi says, we should create a BUILD file with the date at the moment of building.

[durandom]

The reason is, you can bundle update on the same commit, get different gems, and the build is still different

@Fryguy great catch and totally agree with that. But imho anythings better than Time.now, cause thats really misleading. Maybe we replace it by unknown?

@simaishi would you add that BUILD file to upstream builds? Or point me to a place where I can do it?

[simaishi]

Agree Time.now is really confusing... But once we start creating BUILD file for appliances, what we put here becomes less important, as you'll see the output of this line only on dev machines. So whatever works for developers 😄

I'm thinking BUILD file can be added in source_setup.ks.erb. This is where git clone happens.

[durandom]

@Fryguy please have a look again. I just remove Time.now and replaced it with unknown

[durandom]

ManageIQ/manageiq-appliance-build#236 adds a BUILD file to upstream appliances

[miq-bot]

Checked commit durandom@ff44f64 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[durandom]

@Fryguy @carbonin you want to merge this?

[carbonin]

So now the only time we won't have a BUILD file is development, and maybe in containers, correct?

I'm okay with this, if nothing else printing the current time in the build field is misleading at best so I can't see how this isn't an improvement.