Changed Friendly_name to accept Arrays of queue_names #16172
Conversation
juliancheal
force-pushed
the
arrayify_titleize
branch
2 times, most recently
from
1817553 to
c4ab0ca
Compare
|
@miq-bot add_label bug |
|
I couldn't find an exact |
|
@blomquisg @Fryguy what do you think? |
| @@ -9,7 +9,7 @@ def friendly_name | |||
| @friendly_name ||= begin | |||
| ems = ext_management_system | |||
| if ems.nil? | |||
| queue_name.titleize | |||
| queue_name.kind_of?(Array) ? queue_name.collect(&:upcase) : queue_name.titleize | |||
There was a problem hiding this comment.
How about queue_name.collect(&:titleize).join(", ") so you'll get: Ems 1, Ems 2, Ems 3 which is similar to what queue_name.titleize would give you for a single ems ("Ems 1").
There was a problem hiding this comment.
Ah ok, yeah I wasn't too sure what the output should be. So thanks.
There was a problem hiding this comment.
Lol, I just realised I called upcase not titleize #fail
There was a problem hiding this comment.
Lol, I just realised I called upcase not titleize #fail
I think my brain was off, and I just followed Rubocops example! 😂
|
👍 Looks good, can you squash those commits and add the BZ link to the commit message? |
As Amazon is now a single worker with multiple queues, queue_names can be arrays. Joining array to match format of single queue_name This fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1500429
juliancheal
force-pushed
the
arrayify_titleize
branch
from
c30a2ea to
415d229
Compare
|
Checked commit juliancheal@415d229 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Changed Friendly_name to accept Arrays of queue_names
As Amazon is now a single worker with multiple queues, queue_names
can be arrays.