Allow a 'type' setter on MiddlewareServer #16126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'type' into `inventory_object_attributes` so it can be modified when parsing inventory Related to: ManageIQ/manageiq-providers-hawkular#60
|
Checked commit tumido@76fb9f8 with ruby 2.3.1, rubocop 0.47.1, and haml-lint 0.20.0 |
Fryguy
reviewed
Oct 6, 2017
| @@ -27,7 +27,7 @@ def has_middleware_manager_servers(options = {}) | |||
| has_inventory({ | |||
| :model_class => provider_module::MiddlewareManager::MiddlewareServer, | |||
| :association => :middleware_servers, | |||
| :inventory_object_attributes => %i(type_path hostname product lives_on_id lives_on_type | |||
| :inventory_object_attributes => %i(type type_path hostname product lives_on_id lives_on_type | |||
There was a problem hiding this comment.
Is this how we do type for other objects? cc @Ladas
There was a problem hiding this comment.
We do type like this if there are sub STI classes we need to set, which seems to be the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'type' into
inventory_object_attributesso it can be modified when parsing inventoryRelated to: ManageIQ/manageiq-providers-hawkular#60