Print file name on any error from RipperRubyParser, not just SyntaxError #16112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Oct 4, 2017
lib/extensions/descendant_loader.rb
Outdated
| begin | ||
| parsed = RipperRubyParser::Parser.new.parse(content) | ||
| rescue => e | ||
| puts "\nError parsing classes in #{filename}:\n#{e.class.name}: #{e}\n\n" |
There was a problem hiding this comment.
done (used $stderr, it's my impression that's more polite because easily re-assignable)
|
Some comments on commits cben/manageiq@788614b~...217dae0 lib/extensions/descendant_loader.rb
|
|
Checked commits cben/manageiq@788614b~...217dae0 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RipperRubyParser sometimes throws a non-specific RuntimeError. E.g.
mvz/ripper_ruby_parser#3,
mvz/ripper_ruby_parser#5
Whether a real syntax error or a bug, to diagnose we need to see file name
(line and column are normally clear from exception).