-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for physical server timeline #16084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miq-bot add_label enhancement |
lucashsilva
force-pushed
the
XCS-350
branch
2 times, most recently
from
October 9, 2017 17:37
b3261a4
to
4186174
Compare
lucashsilva
changed the title
[WIP] Adds support for physical server timelines and ems physical infra event groups
[WIP] Adds support for physical server timeline
Oct 9, 2017
Checked commits lucashsilva/manageiq@eff5141~...b3261a4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Not sure why the build failed, so restarted it. |
lucashsilva
changed the title
[WIP] Adds support for physical server timeline
Adds support for physical server timeline
Oct 9, 2017
agrare
approved these changes
Oct 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
agrare
added a commit
that referenced
this pull request
Oct 10, 2017
Adds support for physical server timeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists in making timelines available for physical servers.
This PR is in parallel with UI PR 2272