delegate name attribute to parent_manager #16067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durandom
force-pushed
the
parent_manager_delegation
branch
from
eb4338b to
742b0d6
Compare
|
Checked commit durandom@742b0d6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 from me, will wait for feedback from others to merge |
|
@moolitayer here we validate the presence and uniqueness of the name. So, I'd keep setting the name there |
|
👍 from me |
agrare
added a commit
that referenced
this pull request
Sep 29, 2017
delegate name attribute to parent_manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when changing the name of a parent_manager, the name of the child manager is not updated.
because child_manager are mostly read-only, we just delegate the name display to the parent_manager
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1464529
@hsong-rh could you 👍 the change on the storage manager?
@moolitayer could you 👍 the change on the monitoring manager?
@miq-bot assign @agrare
@miq-bot add_label bug