-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rule for network manager to belongsto filter #16063
Merged
gtanzillo
merged 5 commits into
ManageIQ:master
from
lpichler:move_rule_for_network_manager_to_belonsto_filter
Oct 2, 2017
Merged
Move rule for network manager to belongsto filter #16063
gtanzillo
merged 5 commits into
ManageIQ:master
from
lpichler:move_rule_for_network_manager_to_belonsto_filter
Oct 2, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- with enabled belongs to filters related to BZ https://bugzilla.redhat.com/show_bug.cgi?id=1445163
Checked commits lpichler/manageiq@95a23be~...847cbcd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lpichler
changed the title
[WIP] Move rule for network manager to belonsto filter
Move rule for network manager to belonsto filter
Oct 2, 2017
@miq-bot add_label rbac, bug, blocker |
gtanzillo
approved these changes
Oct 2, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
simaishi
pushed a commit
that referenced
this pull request
Oct 2, 2017
…_to_belonsto_filter Move rule for network manager to belonsto filter (cherry picked from commit 99eaef8) https://bugzilla.redhat.com/show_bug.cgi?id=1497835
Fine backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Oct 3, 2017
…_to_belonsto_filter Move rule for network manager to belonsto filter (cherry picked from commit 99eaef8) https://bugzilla.redhat.com/show_bug.cgi?id=1498095
Euwe backport details:
|
chessbyte
changed the title
Move rule for network manager to belonsto filter
Move rule for network manager to belongsto filter
Oct 14, 2017
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…_manager_to_belonsto_filter Move rule for network manager to belonsto filter (cherry picked from commit 99eaef8) https://bugzilla.redhat.com/show_bug.cgi?id=1497835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacement of Allow matching via descendants for CloudNetworks (via network manager) #15271 and Use matching via descendants for CloudNetwork model manageiq-ui-classic#1474
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1487179
ManageIQ/manageiq-ui-classic#2266 - removing old way - not needed for this PR
@miq-bot assign @gtanzillo