Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requests and limits to Persistent Volume Claim #16026

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Add requests and limits to Persistent Volume Claim #16026

merged 1 commit into from
Nov 14, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Sep 24, 2017 •
edited
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1508372

Depends on: ManageIQ/manageiq-schema#74 - Merged

@miq-bot add_label enhancement, providers/containers

@simon3z @zeari Please review

@zakiva zakiva mentioned this pull request Sep 24, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Sep 24, 2017

Checked commit zakiva@de6a04d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@simon3z
Copy link
Contributor

simon3z commented Oct 30, 2017

@miq-bot assign Fryguy
Waiting for ManageIQ/manageiq-schema#74

@miq-bot miq-bot assigned Fryguy and unassigned simon3z Oct 30, 2017
@zakiva zakiva mentioned this pull request Nov 1, 2017
Merged
@zakiva
Copy link
Contributor Author

zakiva commented Nov 1, 2017

@Fryguy @chessbyte Please review

@zakiva
Copy link
Contributor Author

zakiva commented Nov 1, 2017

@miq-bot add_label gaprindashvili/yes

@moolitayer
Copy link

@Fryguy @chessbyte bump

@moolitayer
Copy link

@Fryguy @chessbyte bump

@chessbyte chessbyte assigned chessbyte and unassigned Fryguy Nov 14, 2017
@chessbyte chessbyte merged commit 0874cab into ManageIQ:master Nov 14, 2017
@chessbyte chessbyte added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 14, 2017
@moolitayer
Copy link

moolitayer commented Nov 15, 2017 •
edited
Loading

I'm Removing the Gaprindashvili tag. The Schema PR ins't in Gaprindashvili and I see no Ticket targeted for it.
@miq-bot remove_label gaprindashvili/yes
@miq-bot add_label gaprindashvili/no

@moolitayer
Copy link

My Mistake, ManageIQ/manageiq-schema#74 is in G.
@miq-bot add_label gaprindashvili/yes
@miq-bot remove_label gaprindashvili/no

simaishi pushed a commit that referenced this pull request Nov 15, 2017
@chessbyte @simaishi
Merge pull request #16026 from zakiva/claim_requests_and_limits
53f6cd7 
Add requests and limits to Persistent Volume Claim
(cherry picked from commit 0874cab)

https://bugzilla.redhat.com/show_bug.cgi?id=1513482
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 53f6cd756d1d773a9e12fcc6f0406decea7ac723
Author: Oleg Barenboim <[email protected]>
Date:   Tue Nov 14 10:02:26 2017 +0200

    Merge pull request #16026 from zakiva/claim_requests_and_limits
    
    Add requests and limits to Persistent Volume Claim
    (cherry picked from commit 0874cabba544d86a8c2f7bbae061448b826bbdee)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeari zeari zeari approved these changes

@simon3z simon3z simon3z approved these changes

Assignees

@chessbyte chessbyte

Labels
enhancement gaprindashvili/backported providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zakiva @miq-bot @simon3z @moolitayer @simaishi @zeari @Fryguy @chessbyte