Add event streams product features

[imtayadeway]

In support of https://www.pivotaltracker.com/story/show/149754397

See also ManageIQ/manageiq-api#65

/cc @h-kataria @dclarizio
@miq-bot add-label enhancement
@miq-bot assign @abellotti

[abellotti]

LGTM!! Thanks @imtayadeway

I'll wait for a 👍 from @h-kataria before merging.

[dclarizio]

@abellotti perhaps these new API only features should have their own parent key so they don't get mixed up in the features tree, which currently tried to mimic the UI hierarchy. I discussed with @imtayadeway and we're thinking maybe a parent key for "metrics" and "event_streams" called "api" with a description of "Features Exclusive to the API".

If later they become UI features, we can move them to the appropriate place and, as long as the feature IDs don't change, no code changes will be needed.

[imtayadeway]

@dclarizio I made the suggested changes 👍 LMK if there's anything else 🙇‍♂️

[miq-bot]

Checked commits imtayadeway/manageiq@e43a195~...6b59b0b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[abellotti]

I like the API specific section.

Are these visible in the Classic UI when editing a role ? i.e. being able to setup a role with or without these specific entitlements on any user role or are they only inherited by a super admin ?

[dclarizio]

@abellotti they should! @imtayadeway can you get a screenshot from a User Role screen to verify?

[imtayadeway]

@abellotti @dclarizio it looks like they don't automatically. From what I can grok they have to be added here: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/presenters/menu/default_menu.rb

[h-kataria]

@martinpovolny features added here look good, but i see one issue that these features will not show up on Role Features tree due to the way features tree is being built using menu presenters. API node in this PR will not be presented as a Menu in UI and the way features tree is built we do need a main menu section for all top level features. I think there will be more of these types on node in features tree that will not be presented in UI menus but need to be visible in Features tree, for example SUI, GO etc.
Do you have any suggestions on how we should proceed with showing such items in features tree.

[h-kataria]

@martinpovolny i got API node to show up in Product features tree by changing line https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/presenters/tree_builder_ops_rbac_features.rb#L44 to

%w(all_vm_rules api_exclusive).each do |additional_feature|
      top_nodes << MiqProductFeature.obj_features[additional_feature][:feature]
    end

is that the right way to do it?

[imtayadeway]

@abellotti I think this should be GTG. Thanks so much @dclarizio and @h-kataria !

[martinpovolny]

@h-kataria : yes, that's simply the place where we add the hardcoded exceptions to the generic rules of forming that tree.

[dclarizio]

@imtayadeway @abellotti this is good to go. @h-kataria will create the PR on the UI side to show the API section in the features tree.

[h-kataria]

@abellotti @dclarizio follow up UI PR: ManageIQ/manageiq-ui-classic#2230

[abellotti]

Thank you @imtayadeway for this enhancement and thank you all for your input/recommendations. This LGTM!! 👍