Increase Timeouts and Worker Memory for Azure SSA #16016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label fine/yes |
In support of high priority BZ https://bugzilla.redhat.com/show_bug.cgi?id=1488967 we need to increase various timeouts to allow the Azure SSA job to succeed. 1) Increase the Job timeout specific to Azure SSA similar to how it has been done for SCVMM previously. 2) Increase the SmartProxyWorker MiqQueue msg_timeout value similar to how it has been done for both SCVMM and OpenStack previously. 3) Increase the memory_threshold and restart_interval for all SmartProxyWorker jobs. The memory_threshold issue has been seen running SSA on other providers as well as Azure so the overall default change here is appropriate.
jerryk55
force-pushed
the
increase_msg_timeout_for_azure_ssa
branch
from
191b2a9 to
3b5b283
Compare
|
Checked commit jerryk55@3b5b283 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jrafanie
reviewed
Sep 22, 2017
| @@ -82,6 +82,9 @@ def queue_call(ost) | |||
| if target.kind_of?(ManageIQ::Providers::Openstack::CloudManager::Vm) || | |||
| target.kind_of?(ManageIQ::Providers::Openstack::CloudManager::Template) | |||
| timeout_adj = 4 | |||
| elsif target.kind_of?(ManageIQ::Providers::Azure::CloudManager::Vm) || | |||
| target.kind_of?(ManageIQ::Providers::Azure::CloudManager::Template) | |||
| timeout_adj = 4 | |||
There was a problem hiding this comment.
In the future, we should probably have these classes implement a timeout function so we can just ask the target what it's timeout should be.
There was a problem hiding this comment.
Yup I said something to that effect in the description of the PR.
jrafanie
reviewed
Sep 22, 2017
| @@ -178,6 +178,9 @@ def timeout_adjustment | |||
| if target.kind_of?(ManageIQ::Providers::Microsoft::InfraManager::Vm) || | |||
| target.kind_of?(ManageIQ::Providers::Microsoft::InfraManager::Template) | |||
| timeout_adjustment = 4 | |||
| elsif target.kind_of?(ManageIQ::Providers::Azure::CloudManager::Vm) || | |||
| target.kind_of?(ManageIQ::Providers::Azure::CloudManager::Template) | |||
| timeout_adjustment = 4 | |||
|
@miq-bot add_label smart state |
|
@miq-bot add_label fine/yes |
|
@miq-bot Y U NO WORK |
|
😵 |
|
@jrafanie that is cheating... no logging into the bot account... |
|
@jrafanie unrecognized command 'Y', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
I'm fine with the code change. There's no test even though the @roliveri please review/merge. |
roliveri
approved these changes
Sep 22, 2017
simaishi
pushed a commit
that referenced
this pull request
Sep 22, 2017
…e_ssa Increase Timeouts and Worker Memory for Azure SSA (cherry picked from commit a3c9213) https://bugzilla.redhat.com/show_bug.cgi?id=1488967
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…for_azure_ssa Increase Timeouts and Worker Memory for Azure SSA (cherry picked from commit a3c9213) https://bugzilla.redhat.com/show_bug.cgi?id=1488967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of high priority BZ https://bugzilla.redhat.com/show_bug.cgi?id=1488967
we need to increase various timeouts to allow the Azure SSA job to succeed.
done for SCVMM previously.
been done for both SCVMM and OpenStack previously.
The memory_threshold issue has been seen running SSA on other providers as well as
Azure so the overall default change here is appropriate.
Other PRs are related to the BZ as well but this PR may be merged in any order as there
are no prerequisites for it.
This PR should be back ported to FINE.
Please note that we should probably refactor the timeout code in items 1 and 2 above to distribute it to the Providers in question rather than have it live in the ManageIQ repo but that is an item for another day.
Links
Steps for Testing/QA [Optional]
Run SSA on various providers including Azure - especially with Managed Disks. along with other required PRs referenced in the BZ above the scan should complete.
@roliveri @jrafanie please review and merge as soon as possible to allow us to get this BZ addressed.