Change error notification level from success to error #15998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
fix_ansible_notification
branch
from
7eeb43e to
36583a3
Compare
jameswnl
approved these changes
Sep 20, 2017
|
Checked commit ZitaNemeckova@36583a3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 10, 2017
Change error notification level from success to error (cherry picked from commit 5448263) https://bugzilla.redhat.com/show_bug.cgi?id=1496908
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…fication Change error notification level from success to error (cherry picked from commit 5448263) https://bugzilla.redhat.com/show_bug.cgi?id=1496908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible Tower failure notification had wrong level. Changed from
successtoerrorso the notification displays red cross instead of green checkmark. Introduced by #14625 .@miq-bot add_label bug, providers/ansible_tower, fine/yes
@jameswnl Please review. Thanks :)
https://bugzilla.redhat.com/show_bug.cgi?id=1471868