Ruby 2.4 - Replace all Fixnum|Bignum #15987
Conversation
|
I don't know if this should be backported to Fine or not. Maybe? |
Both are deprecated in favor of Integer https://bugs.ruby-lang.org/issues/12005
chrisarcand
force-pushed
the
ruby-2-4-integer
branch
from
11080ce to
0c21d70
Compare
|
Checked commit chrisarcand@0c21d70 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
So, @jrafanie had started a top-level issue that brought these kinds of things together. As such, let's use that to coordinate merges of these kinds of changes because we need to ensure that we support 2.2 and 2.3 until some designated switchover date, when we plan to drop support of 2.2 and only support 2.3 and 2.4. |
I don't expect we would go back to an old release to and bump the Ruby version there, so no. |
Yup. Just laying the groundwork; this PR is 100% compatible with Ruby 2.3 |
|
Is it compatible with Ruby 2.2? If so, I can just merge now |
|
@Fryguy Yup, totally compatible with 2.2. |
| @@ -912,7 +912,7 @@ | |||
| :mem_minimum: 32.megabytes | |||
| :reporting: | |||
| :format_by_class: | |||
There was a problem hiding this comment.
WAT. I smell a deletion... It's mine!
Many years ago their usage was removed from the generic server settings and migrated in a way to each report's settings...
commit 73ac8da10e3bc0eed2abc471ca89adce222f0700
Author: <REDACTED>
Date: Wed Dec 16 21:20:47 2009 +0000
-Changed args in format method to take an options hash instead of format as the last arg to allow passing additional options such as time zone.
-Updated callers of format method.
-Support for passing in :_default_ as format value to force default lookup of format and not look in report object.
-Added support for date, time and datetime formats.
BugzID: 7453
git-svn-id: http://miq-ubuntusub.manageiq.com/svn/svnrepos/Manageiq/trunk@17795 3c68ef56-dcc3-11dc-9475-a42b84ecc76f
Seen when reviewing: ManageIQ#15987
Both are deprecated in favor of Integer
https://bugs.ruby-lang.org/issues/12005