-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support publish Vm by RHV #15981
Support publish Vm by RHV #15981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, just a few minor questions.
true: 1 | ||
:description: Choose Automatically | ||
:required: false | ||
:display: :hide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this option need to be hidden? Can't auto-placement still be used to select the target cluster?
Also, why was :placement_dc_name
removed from this section? I would think that could still be used for filtering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On RHV the user can create a template from the VM only on the same DC (restricted due to resources shared between the same DC, i.e. networks), therefore showing the DC might be misleading to the user.
I'll enable the auto-placements.
true: 1 | ||
:description: Power on virtual machines after creation | ||
:required: false | ||
:display: :edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this field should not be displayed, suggest using :display: :hide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct. it shouldn't be displayed. Seems that it is hidden in the attached screenshots regardless of the value of :display.
Nevertheless, I'll change its value to :hide
RHV provider supports creating a template from a virtual machine. The dialog introduces the supported options for RHV, including sealing a template after its creation. https://bugzilla.redhat.com/show_bug.cgi?id=1373076
3c41c7f
to
d5c56a3
Compare
Checked commit masayag@d5c56a3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
RHV provider supports creating a template from a virtual machine.
The dialog introduces the supported options for RHV, including sealing a
template after its creation.
https://bugzilla.redhat.com/show_bug.cgi?id=1373076
Screenshots are available here