Add orchestration stack targeted refresh method #15936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add orchestration stack targeted refresh method, that based on settings will perform targeted or full refresh.
2 tasks
Add class method for OrchestrationStack refresh
|
Checked commits Ladas/manageiq@0537cc8~...300deb4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
reviewed
Sep 7, 2017
| # Queue new targeted refresh if allowed | ||
| orchestration_stack_target = ManagerRefresh::Target.new(:manager => manager, | ||
| :association => :orchestration_stacks, | ||
| :manager_ref => {:ems_ref => manager_ref}) |
There was a problem hiding this comment.
Much better than refresh_new_target 👍
agrare
reviewed
Sep 7, 2017
| end | ||
| unless manager.authentication_status_ok? | ||
| raise _("%{table} failed last authentication check") % {:table => ui_lookup(:table => "ext_management_systems")} | ||
| end |
There was a problem hiding this comment.
We should move these conditions to a common method, the same code pattern is in ext_management_system, host, and two places in vm_or_template
There was a problem hiding this comment.
yes, I plan to extract it
agrare
approved these changes
Sep 7, 2017
agrare
added a commit
that referenced
this pull request
Sep 7, 2017
…ation_stack Add orchestration stack targeted refresh method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add orchestration stack targeted refresh method, that based on
settings will perform targeted or full refresh.
Required by:
ManageIQ/manageiq-automation_engine#68
ManageIQ/manageiq-content#182