Add nil checks for manager_uuids and references #15934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ladas can you look at the spec failures? They seem legitimate |
|
@agrare yes, will do |
Add nil checks for manager_uuids and references, nil references lead to non existent elements, so we don't want them stored.
Ladas
force-pushed
the
add_nil_check_for_manager_uuids_and_references
branch
from
7d8dce0 to
17c884a
Compare
|
Checked commit Ladas@17c884a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Sep 26, 2017
…r_uuids_and_references Add nil checks for manager_uuids and references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nil checks for manager_uuids and references, nil references lead to non existent elements, so we don't want them stored.
Also some events could cause a nil reference leading to failed refresh, so this is a bugfix for targeted refresh.