Apply distinct on lans and switches #15930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
reviewed
Sep 4, 2017
| @@ -0,0 +1,496 @@ | |||
| --- | |||
There was a problem hiding this comment.
seems like this doesn't belong to this PR?
There was a problem hiding this comment.
How did that get there....
I'll remove it.
Ladas
suggested changes
Sep 4, 2017
Several hosts might be connected to the same switch, sharing the same LAN. Therefore it is required to apply 'DISTINCT' on the result of the join of these tables.
masayag
force-pushed
the
apply_distinct_on_lans_and_switches
branch
from
86a00c4 to
7e6ab4f
Compare
|
Checked commit masayag@7e6ab4f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
pkliczewski
approved these changes
Sep 4, 2017
|
@Ladas can we merge this ? |
|
@agrare Can you please review? |
agrare
added a commit
that referenced
this pull request
Sep 12, 2017
…tches Apply distinct on lans and switches
|
@masayag can you see if https://travis-ci.org/ManageIQ/manageiq/jobs/274592893#L1255 is related to this PR? |
|
@agrare From what I see it can be random ordering bug, given we compare association[0] to something |
|
@Ladas yeah you're right, nevermind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several hosts might be connected to the same switch, sharing the same LAN. Therefore it is required to apply 'DISTINCT' on the result of joining these tables.
Steps for Testing/QA [Optional]
On RHV provider, have 2 hosts which are connected to the same network.