Generic object enhancement.

[lfu]

Some changes to generic object.

• Use save! over save to be API call ready.
• Convert input to string format as keywords in properties hash are all in string format.
• Enhance GenericObject#delete_property to work for both property attributes and associations.
• Add GenericObject#property_associations.

@miq-bot assign @gmcculloug
@miq-bot add_label enhancement

cc @jntullo

[jntullo]

Thanks for the update @lfu! 👍

[lfu]

cc @bzwei

[bzwei]

Instead of converting all attribute names to string to_s, how about all to symbols?

[bzwei]

Instead of inserting require_generic_object_definition for almost every method we can have a before_save hook to ensure the existence of definition.

[lfu]

@bzwei Jsonb column has all keywords stored in String format. So I think String format may be more appropriate.
It is possible that the generic object has the definition in DB but somehow the definition object does not exist. I would like each method checks the existence of the definition before it does the work which may make the debugging easier in the future.

[bzwei]

Is it a valid use case that "It is possible that the generic object has the definition in DB but somehow the definition object does not exist"? In a production it is a penalty to validate for every method call. If it is for the debugging purpose then the code should exist only in debug mode (although I don't know how)

[gmcculloug]

Instead of creating a local variable you can use tap here to return the result of _property_getter(name)

_property_getter(name).tap do
  properties.delete(name.to_s)
  save!
end

[gmcculloug]

@lfu Please review this PR description to make sure it is still accurate.

[gmcculloug]

@bzwei PTAL

[bzwei]

Do we need to explicitly check for properties_changed??. I think save! internally does the check.

[miq-bot]

Checked commits lfu/manageiq@71794cf~...2009663 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 👍