Added support for httpd auth-api service for containers. #15881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellotti
force-pushed
the
ext-auth-api-service
branch
from
892cc2b to
0c7f4f8
Compare
abellotti
force-pushed
the
ext-auth-api-service
branch
from
2d0ef80 to
2a69c87
Compare
|
This pull request is not mergeable. Please rebase and repush. |
abellotti
force-pushed
the
ext-auth-api-service
branch
3 times, most recently
from
5cf8993 to
a7a610f
Compare
abellotti
changed the title
abellotti
force-pushed
the
ext-auth-api-service
branch
from
a7a610f to
4a8721a
Compare
abellotti
force-pushed
the
ext-auth-api-service
branch
2 times, most recently
from
6247173 to
a708ff9
Compare
abellotti
force-pushed
the
ext-auth-api-service
branch
from
a708ff9 to
826a38d
Compare
|
I have no idea what the |
|
If it's going into services, it should be namespaced properly for autoload, so it should be Services::AuthApiService, which I don't like. I think it should just be in the lib directory directly. |
|
With it not being in lib/services, maybe it should also be renamed to HttpdAuthApi. Thoughts ? |
|
I'm good with HttpdAuthApi |
- Enhanced fetching user attributes via dbus to use the httpd auth-api service for containers. - Enhanced fetching user groups via dbus to use the httpd auth-api service for containers. - Updated rspecs
- dbus dropped from the URL - Moved logic to a common AuthApiService - Added tests for AuthApiService
- Moved the library from lib/services/auth_api_service.rb to lib/httpd_auth_api.rb
abellotti
force-pushed
the
ext-auth-api-service
branch
from
826a38d to
0fb40b1
Compare
|
Checked commits abellotti/manageiq@6dc35a1~...0fb40b1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
carbonin
reviewed
Sep 11, 2017
| def auth_api(request_url) | ||
| host = ENV["HTTPD_AUTH_API_SERVICE_HOST"] | ||
| port = ENV["HTTPD_AUTH_API_SERVICE_PORT"] | ||
| conn = Faraday.new(:url => "http://#{host}:#{port}") do |faraday| |
There was a problem hiding this comment.
Should this use the URI::HTTP.build?
carbonin
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: