Remove rails-controller-testing from Gemfile #15852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
force-pushed
the
move-rails-controller-testing-gem-to-ui
branch
from
0d60ef1 to
273d335
Compare
ManageIQ/manageiq-ui-classic should be the only repo that is currently needing this gem (possibly ManageIQ/manageiq-api), so make those dev dependencies for those projects directly, and prevent them from being required by every other project that doesn't need them.
|
Checked commit NickLaMuro@273d335 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
For the record, I have been running the |
bdunne
modified the milestones:
Sprint 67 Ending Aug 21, 2017,
Sprint 68 Ending Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ/manageiq-ui-classic should be the only repo that is currently needing this gem (possibly ManageIQ/manageiq-api), so make those dev dependencies for those projects directly, and prevent them from being required by every other project that inherits from this one doesn't need
rails-controller-testing.Merge order between this PR and ManageIQ/manageiq-ui-classic#1953 is something that should be discussed.
Links
Steps for Testing/QA
The test suite running find should be enough of an indicator that this works fine in this repo.