Add new classes to BUTTON_CLASSES #15845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new classes to have custom buttons
ZitaNemeckova
force-pushed
the
custom_classes
branch
from
7b96f17 to
d83e3cf
Compare
|
Checked commit ZitaNemeckova@d83e3cf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
approved these changes
Aug 18, 2017
There was a problem hiding this comment.
looks good but need to wait for ManageIQ/manageiq-ui-classic#1912 to be finished.
h-kataria
reviewed
Aug 18, 2017
There was a problem hiding this comment.
it will be good to wait to merge this until WIP label is removed from ManageIQ/manageiq-ui-classic#1912 , otherwise there will be some missing icons in the tree
|
@dclarizio UI PR is ready, can you merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new classes to have custom buttons.
(Toolbar builder expects
ContainerVolumeforPersistentVolumeController.)https://www.pivotaltracker.com/story/show/147778977
@miq-bot add_label automate, enhancement, fine/no
UI PR: ManageIQ/manageiq-ui-classic#1912
@h-kataria please have a look, thanks :)