Fix for problem with miq_group (find_by_description) #15813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit arnikasky@e809fa5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/miq_group.rb
|
kbrock
requested changes
Aug 22, 2017
There was a problem hiding this comment.
Good eye,
Please move the fix up a few lines.
Or just ping me and I can introduce the change.
(I offer to you so you can get credit)
Also, you probably want to make these changes on a branch instead of your master - but that is just to make your life easier. all the same for the merger
| @@ -64,7 +64,7 @@ def self.seed | |||
| roles = MiqUserRole.where("name like 'EvmRole-%'").index_by(&:name) | |||
|
|
|||
| role_map.each_with_index do |(group_name, role_name), index| | |||
| group = groups[group_name] || new(:description => group_name) | |||
| group = MiqGroup.where(description: group_name, tenant_id: Tenant.root_tenant).first || new(:description => group_name) | |||
There was a problem hiding this comment.
The introduction of groups was to avoid the N+1. This adds it back.
Introduce this change 3 lines up creating groups.
groups = where(:group_type => SYSTEM_GROUP, tenant_id: Tenant.root_tenant).includes(:entitlement).index_by(&:description)
|
Closing in lieu of #15876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, developers
It's my fix for issue #15700
Faced with issue, when had problem with database and first record which was taken from database, was wring.
Best Regards,
Hanna Novikava