Add metrics default limit to API settings #15797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit jntullo@e3f11f3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Not a blocker for this PR (which otherwise looks good), but should these settings live in the API repo? |
|
LGTM!! Thanks @jntullo 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the default limit for the amount of metric rollups that will be returned from the API.
API pr: ManageIQ/manageiq-api#4
@miq-bot add_label api
@miq-bot assign @abellotti
cc: @gtanzillo