Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web service worker needs to load MiqAeDomain, etc. #15769

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Aug 8, 2017

https://github.com/ManageIQ/manageiq-api/blob/01d6d3c05e497b658558a64d8855daf7297a9e6b/config/api.yml#L218-L232

The whitelist of bundler groups are the only gems we can require/load so
we need to add anything we might possibly load in this list.

https://github.com/ManageIQ/manageiq-api/blob/01d6d3c05e497b658558a64d8855daf7297a9e6b/config/api.yml#L218-L232

The whitelist of bundler groups are the only gems we can require/load so
we need to add anything we might possibly load in this list.
@miq-bot
Copy link
Member

miq-bot commented Aug 8, 2017

Checked commit jrafanie@f94df3f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy
Copy link
Member

Fryguy commented Aug 8, 2017

That stinks. IMO, the models should not live there...only the engine specific parts of those models :/

@jrafanie
Copy link
Member Author

jrafanie commented Aug 8, 2017

That stinks. IMO, the models should not live there...only the engine specific parts of those models :/

@Fryguy the nice thing is we can run BUNDLER_GROUPS="rest_api,web_server,automate" bin/rails server and try to hit the server with rest calls and start dialing back the dependencies, fixing any we can easily workaround, and start dropping them.

@Fryguy
Copy link
Member

Fryguy commented Aug 9, 2017

cc @gmcculloug @mkanoor

@bdunne bdunne merged commit d2e75f2 into ManageIQ:master Aug 9, 2017
@bdunne bdunne added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 9, 2017
@jrafanie jrafanie deleted the api_code_requires_automate branch August 10, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants