-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register product features for JDR reports #15768
Conversation
JDR report fetures are registered as an admin feature under middleware servers.
a0a5260
to
4d1974e
Compare
Checked commit israel-hdez@4d1974e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@miq-bot add_label enhancement, providers/hawkular |
@chessbyte who would be the best person to review/merge this? |
@israel-hdez is there a related UI PR for these new features? |
@h-kataria Yes, this one: ManageIQ/manageiq-ui-classic#1764 |
@israel-hdez i only see Generate report button on that PR https://github.com/ManageIQ/manageiq-ui-classic/pull/1764/files#diff-e6f07e5cdde7794bbc9e7cac60727879R187 , is Delete button in a different PR? |
@h-kataria Oh! I moved the delete button from main toolbar to a secondary toolbar. It's, indeed, a good catch in the UI. I just updated the PR and now you can find it here: https://github.com/ManageIQ/manageiq-ui-classic/pull/1764/files#diff-002598c1d95530eae2e85c719166439fR27. |
@h-kataria - look good to go? |
@h-kataria I can merge with your approval. |
@chessbyte looks good, please merge. |
JDR report fetures are registered as an admin feature under middleware
servers.
Jira: https://issues.jboss.org/browse/HAWKULAR-1231