Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register product features for JDR reports #15768

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

israel-hdez
Copy link
Member

JDR report fetures are registered as an admin feature under middleware
servers.

Jira: https://issues.jboss.org/browse/HAWKULAR-1231

JDR report fetures are registered as an admin feature under middleware
servers.
@miq-bot
Copy link
Member

miq-bot commented Aug 8, 2017

Checked commit israel-hdez@4d1974e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@abonas
Copy link
Member

abonas commented Aug 9, 2017

@miq-bot add_label enhancement, providers/hawkular
LGTM
@miq-bot assign @chessbyte
@chessbyte who would be the best person to review/merge this?

@abonas
Copy link
Member

abonas commented Aug 24, 2017

@chessbyte who would be the best person to review/merge this?

@h-kataria
Copy link
Contributor

@israel-hdez is there a related UI PR for these new features?

@israel-hdez
Copy link
Member Author

@h-kataria Yes, this one: ManageIQ/manageiq-ui-classic#1764

@h-kataria
Copy link
Contributor

@israel-hdez i only see Generate report button on that PR https://github.com/ManageIQ/manageiq-ui-classic/pull/1764/files#diff-e6f07e5cdde7794bbc9e7cac60727879R187 , is Delete button in a different PR?

@israel-hdez
Copy link
Member Author

@h-kataria Oh! I moved the delete button from main toolbar to a secondary toolbar. It's, indeed, a good catch in the UI. I just updated the PR and now you can find it here: https://github.com/ManageIQ/manageiq-ui-classic/pull/1764/files#diff-002598c1d95530eae2e85c719166439fR27.

@bronaghs
Copy link

@h-kataria - look good to go?

@chessbyte
Copy link
Member

@h-kataria I can merge with your approval.

@h-kataria
Copy link
Contributor

@chessbyte looks good, please merge.

@chrisarcand chrisarcand merged commit 8e228e9 into ManageIQ:master Sep 1, 2017
@chrisarcand chrisarcand added this to the Sprint 68 Ending Sep 4, 2017 milestone Sep 1, 2017
@israel-hdez israel-hdez deleted the jdr_feature branch September 1, 2017 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants