Removes importer association data for backwards compatibility #15724
Conversation
|
@miq-bot assign @gmcculloug |
d-m-u
force-pushed
the
make_associations_backwards_compatible
branch
from
21e5228 to
bb884ac
Compare
| } | ||
| end | ||
|
|
||
| let(:responder) { FactoryGirl.create(:dialog_field) } |
There was a problem hiding this comment.
Do we need this? We're deleting the key anyway in the import process, I don't think there's any reason to actually create a dialog field in the test if we're just throwing it away.
There was a problem hiding this comment.
Let me clarify since I know it sounds like I'm contradicting myself from my previous suggestion of adding the dialog_field_responders into the test. I was basically just saying to add the key and a nonsense value to ensure that even if the importing yaml contained the key, it would be ignored.
d-m-u
force-pushed
the
make_associations_backwards_compatible
branch
2 times, most recently
from
344e82b to
239ce78
Compare
d-m-u
changed the title
d-m-u
changed the title
d-m-u
force-pushed
the
make_associations_backwards_compatible
branch
from
239ce78 to
089b4b6
Compare
d-m-u
changed the title
|
Checked commits d-m-u/manageiq@8d80d93~...089b4b6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This PR removes the dialog field association data from the fields currently imported by the main repo (which takes only expected dialog fields sans associations). We take out the information related to ResourceActions in much the same fashion here as well.
Related to:
#15608
(the export code is here:)
#15740