Force status removal and default value #15685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, provisioning, services @miq-bot assign @gmcculloug |
|
-- cc @tinaafitz |
syncrou
force-pushed
the
no_longer_copy_denied_state
branch
from
09ecdf5 to
110aac7
Compare
When we copy the MiqRequest to MiqRequestTask there is a case where status was not passing validation if it was originally set to 'Denied' This addresses that issue by removing the status column at copy and then setting the default value to 'Ok' in the MiqRequestTask https://bugzilla.redhat.com/show_bug.cgi?id=1460158
syncrou
force-pushed
the
no_longer_copy_denied_state
branch
from
110aac7 to
25bdd91
Compare
|
Checked commit syncrou@25bdd91 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
gmcculloug
approved these changes
Jul 31, 2017
simaishi
pushed a commit
that referenced
this pull request
Aug 2, 2017
Force status removal and default value (cherry picked from commit 7db49cd) https://bugzilla.redhat.com/show_bug.cgi?id=1477616
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 2, 2017
Force status removal and default value (cherry picked from commit 7db49cd) https://bugzilla.redhat.com/show_bug.cgi?id=1477617
|
Euwe backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…state Force status removal and default value (cherry picked from commit 7db49cd) https://bugzilla.redhat.com/show_bug.cgi?id=1477616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we copy the
MiqRequesttoMiqRequestTaskthere is a case where status was not passing validation if it was originally set to 'Denied'This addresses that issue by removing the
statuscolumn at copy and then setting the default value ofstatusto 'Ok' in theMiqRequestTaskhttps://bugzilla.redhat.com/show_bug.cgi?id=1460158