Raise creation event batched job #15679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cben
reviewed
Jul 30, 2017
app/models/container_image.rb
Outdated
| @@ -75,6 +75,12 @@ def perform_metadata_scan(ost) | |||
| scan_via_miq_vm(miq_cnt_group, ost) | |||
| end | |||
|
|
|||
| def self.raise_creation_event(container_image_ids) | |||
There was a problem hiding this comment.
Consider naming it plural raise_creation_events.
There was a problem hiding this comment.
yeah, that make sense
cben
approved these changes
Jul 30, 2017
There was a problem hiding this comment.
👍
cc @enoodle (see ManageIQ/manageiq-providers-kubernetes#77 for context)
Raise creation event batched job, sparing queries and trying not to bloat MiqQueue.
Ladas
force-pushed
the
raise_creation_event_batched_job
branch
from
2f96f9b to
3565c87
Compare
|
Checked commit Ladas@3565c87 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise creation event batched job, sparing queries and trying not to bloat MiqQueue. This is needed for the Graph Refresh batch processing. The old refresh does not support batch processing of any kind.