Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] MiqSearch.seed #15666

Merged
merged 1 commit into from
Sep 25, 2017
Merged

[Performance] MiqSearch.seed #15666

merged 1 commit into from
Sep 25, 2017

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jul 27, 2017 •
edited
Loading

Since we run seeds on every appliance boot, and it blocks all other appliances from booting, the goal is to get seeds as fast as possible.

  • remove N+1 lookups to miq_searches
  • remove duplicate records in yaml file.
  • display warning for duplicate records in yaml file.
  • Was saving all records since it thought filter had changed. Fixes false positives.
ms bytes objects query query ms rows comments
1,590.1 33,844,512 401,337 602 886.3 119 before
90.2 4,622,977 58,704 1 4.3 117 after
94% 86% 85% 99.9% 99.5% 2% diff

related to:

@kbrock kbrock force-pushed the seeding_miq_search branch from 642f6c9 to 392884b Compare August 1, 2017 14:04
@kbrock
Copy link
Member Author

kbrock commented Aug 1, 2017

  • simplified dedup detection
  • removed rubocop warnings

@kbrock
MiqSearch.seed
f3b00fc 
- remove N+1
- remove duplicate records
- display warning for duplicate records
@kbrock
Copy link
Member Author

kbrock commented Sep 21, 2017 •
edited
Loading

No changes. Rebased to test against the current master.

@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2017

Checked commit kbrock@f3b00fc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

gtanzillo
gtanzillo approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! 👍

@gtanzillo gtanzillo added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 25, 2017
@gtanzillo gtanzillo merged commit 34ff707 into ManageIQ:master Sep 25, 2017
@kbrock kbrock deleted the seeding_miq_search branch September 25, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
core performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbrock @miq-bot @gtanzillo